Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContractFactory provider type #151

Closed
fracek opened this issue Mar 22, 2022 · 1 comment
Closed

ContractFactory provider type #151

fracek opened this issue Mar 22, 2022 · 1 comment

Comments

@fracek
Copy link
Contributor

fracek commented Mar 22, 2022 •
edited

The type of providerOrAccount in the ContractFactory constructor is currently a Provider | Account. Should it be a ProviderInterface | ContractInterface instead?
@janek26
Copy link
Member

janek26 commented Mar 22, 2022

yes it should, thanks

@MilGard91 MilGard91 mentioned this issue Apr 20, 2022
Merged
@janek26 janek26 closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fracek @janek26