Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SNIP-9 #948

Open
ivpavici opened this issue Feb 2, 2024 · 2 comments · May be fixed by #1111
Open

Add support for SNIP-9 #948

ivpavici opened this issue Feb 2, 2024 · 2 comments · May be fixed by #1111
Assignees
@kfastov
Labels
Difficulty: hard require extensive knowledge about the field ODHack Issue to assign for the ODHack event OnlyDust Open for OnlyDust contributors Type: feature New feature or request

Comments

@ivpavici
Copy link
Collaborator

ivpavici commented Feb 2, 2024

More details:

https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-9.md

Initial thoughts (credits to @PhilippeR26 ):

  • We need a function that will create TypedData, hash it, and include all this in an object that will be the result of the function. (Nothing is explained in the snip how to construct this TypedData, and which hash to use)
  • support the call of the entrypoint execute_from_outside
  • We need also a function that checks that an account contract can handle this type of tx, and then send this special tx ( execute_from_outside ).
@ivpavici ivpavici added the Type: feature New feature or request label Feb 2, 2024
@ivpavici ivpavici added OnlyDust Open for OnlyDust contributors ODHack Issue to assign for the ODHack event Difficulty: hard require extensive knowledge about the field labels Apr 19, 2024
@kfastov
Copy link

kfastov commented Apr 22, 2024

Hello! Can I please tackle this one?
I've implemented SNIP-12 signatures verification on-chain (which seems related) and participated in the previous ODHack.
I plan to study the related SNIPs, and discuss with community all details that are unclear,
check the documentation of the execute_from_outside entrypoint and its source code if needed, and then implement the functions mentioned in this task

@ivpavici
Copy link
Collaborator Author

ok, sure @kfastov good luck!

@kfastov kfastov linked a pull request May 1, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfastov kfastov

Labels
Difficulty: hard require extensive knowledge about the field ODHack Issue to assign for the ODHack event OnlyDust Open for OnlyDust contributors Type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement SNIP-9 (WiP) kfastov/starknet.js
2 participants
@kfastov @ivpavici