Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calldata decoder & API Encoder (with ABI) #952

Open
tabaktoni opened this issue Feb 6, 2024 · 3 comments · May be fixed by #1018
Open

Calldata decoder & API Encoder (with ABI) #952

tabaktoni opened this issue Feb 6, 2024 · 3 comments · May be fixed by #1018
Assignees
Labels
OnlyDust Open for OnlyDust contributors Type: feature New feature or request

Comments

@tabaktoni
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
This feature is nice to have as tools could use it and build on it.
Currently, we support encoding &. decoding with ABI:
JSC types -> calldata
responsedata -> JSC types

Describe the solution you'd like
It would also be nice to have a calldata decoder:
calldata -> JSC types
and api data encoder:
JSC types -> responsedata
Internally we do not need such a flow other than maybe adding additional validation options/ testing,
but this could help

  1. case: describe calldata parameters for various explorers &. tools.
  2. case: encode response for rpc node & tools.

Additional context
With ABI this would complete a circle of data conversion as so one could do:
calldata -> JSC types -> responsedata
We could improve the test with excepted results for echo test methods

@tabaktoni tabaktoni added Type: feature New feature or request OnlyDust Open for OnlyDust contributors labels Feb 6, 2024
@AryanGodara
Copy link

Hi @tabaktoni ; Can I work on this issue?
I've been reading up on the repo, for some time now.
I initially saw it on OnlyDust, and asked @ivpavici if I could work on this one.
Looks like no one else has picked this issue yet :D

@AryanGodara
Copy link

@ivpavici Thanks for assigning this to me. :D
I won't be able to get to it before coming Monday, because of some other obligations 😅
But this is in my list and I'll try to push the relevant changes in a few days.

@ivpavici
Copy link
Collaborator

ivpavici commented Mar 6, 2024

no worries, take your time!

@AryanGodara AryanGodara linked a pull request Mar 15, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OnlyDust Open for OnlyDust contributors Type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants