Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve package dependency on Abi Wan #957

Open
tabaktoni opened this issue Feb 8, 2024 · 7 comments
Open

Resolve package dependency on Abi Wan #957

tabaktoni opened this issue Feb 8, 2024 · 7 comments
Assignees
Labels
OnlyDust Open for OnlyDust contributors Type: bug Something isn't working

Comments

@tabaktoni
Copy link
Collaborator

tabaktoni commented Feb 8, 2024

Describe the bug
starknet@5.24.3 - 7.7MB / 14 packages
starknet@6.0.0 - 123MB / 46 packages

The issue is in Abi wan CLI packages for js to ts conversion
This is both security and package size issue.
We want to reduce dependency graph to lowest possible footprint

To Screenshots
1
2

To Reproduce
https://pkg-size.dev/starknet@5.24.3
https://pkg-size.dev/starknet@6.0.0

Additional context
My recommendation for fixing this is:

  • removing any non-essential stuff from abi-wan dependency
  • remove script for js -> ts conversion from abi-wan package and deploy separately to npm
  • script is used with npx so it doesn't need to be part of default package
  • fix abi one dist to only TS decoder/encoder with no additional files besides dist
  • use same TS versions so npm do not install both v4.9.5 and typescript v5.3.3
@tabaktoni tabaktoni added Type: bug Something isn't working OnlyDust Open for OnlyDust contributors labels Feb 8, 2024
@GoSTEAN
Copy link

GoSTEAN commented Apr 2, 2024

Hi @tabaktoni Please can this be assign to me. Thank you.

@ivpavici
Copy link
Collaborator

ivpavici commented Apr 3, 2024

@GoSTEAN good luck!

@ivpavici
Copy link
Collaborator

@GoSTEAN hi! any progress?

@GoSTEAN
Copy link

GoSTEAN commented Apr 16, 2024

@ivpavici yes there is progress and I will be done soon. Thank you for your patience.

@ivpavici
Copy link
Collaborator

ok if not done until 22nd I will offer this task on the ODHack event
https://onlydust.notion.site/ODHack-Common-Guidelines-b9c6b6a4ac4146d087185568aca38a3f

@GoSTEAN
Copy link

GoSTEAN commented Apr 20, 2024

@ivpavici I have created a PR

@GoSTEAN
Copy link

GoSTEAN commented Apr 20, 2024

@ivpavici #1091 the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OnlyDust Open for OnlyDust contributors Type: bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants