Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OsResources vs OSConstants #1682

Open
tdelabro opened this issue Mar 18, 2024 · 1 comment
Open

OsResources vs OSConstants #1682

tdelabro opened this issue Mar 18, 2024 · 1 comment

Comments

@tdelabro
Copy link
Contributor

https://github.com/starkware-libs/blockifier/blob/1f54a54fc143b6a0de365479407a9f6070388865/crates/blockifier/src/versioned_constants.rs#L53C3-L57C1

There are inconsistencies in the naming of types starting with Os. Should it be Os or OS? It doesn't really matter IMO, as long as it is consistent across the crate.
@tdelabro
Copy link
Contributor Author

As both types are exposed, changing the naming of one or the other will be a breaking change and require a major semver bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tdelabro