Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatched versions in specification files #181

Closed
FabijanC opened this issue Dec 6, 2023 · 1 comment · Fixed by #183 · May be fixed by #182
Closed

Mismatched versions in specification files #181

FabijanC opened this issue Dec 6, 2023 · 1 comment · Fixed by #183 · May be fixed by #182

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Dec 6, 2023

As of spec version v0.6.0-rc5, while api/starknet_api_openrpc.json has version: 0.6.0, the write and trace files have 0.5.0.

Is this on purpose? Should the versioning of every file really be independent? I feel like something is wrong because in v0.5.1, the version in all three files was indeed 0.5.1.

If this really is a mistake, a good idea would be to improve the validation workflow this repository uses (namely validate.js). Perhaps it could use the version property in package.json as the source of truth, and check all the spec files against that. I'd be willing to make a contribution.
@Mirko-von-Leipzig
Copy link
Contributor

Fairly sure it's not on purpose. I think go ahead with adding the CI check; always nice to not worry about it.

This was referenced Dec 6, 2023
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@FabijanC @Mirko-von-Leipzig