Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: typescript support #10

Merged
merged 8 commits into from May 7, 2023
Merged

feat: typescript support #10

merged 8 commits into from May 7, 2023

Conversation

dan-ziv
Copy link
Collaborator

@dan-ziv dan-ziv commented Oct 12, 2022 •
edited

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

Check List

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the convention: <type>[optional scope]: <description>, e.g: fix: minor typos in code

@dan-ziv dan-ziv marked this pull request as draft October 12, 2022 12:31
@dan-ziv dan-ziv marked this pull request as ready for review May 5, 2023 21:28
@dan-ziv dan-ziv changed the title feat: typescript-support feat: typescript support May 5, 2023
@AlonStark AlonStark self-requested a review May 7, 2023 07:17
AlonStark
AlonStark previously approved these changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@AlonStark AlonStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan-ziv dan-ziv merged commit bcdb84b into dev May 7, 2023
2 checks passed
@dan-ziv dan-ziv deleted the typescript-support branch May 7, 2023 07:35
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
910cb51 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented May 7, 2023

🎉 This PR is included in version 0.1.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
99d9b0e 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
37624c7 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
18d34a2 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
6bdcbb9 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
3c5fff6 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented May 7, 2023

🎉 This PR is included in version 0.1.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
release: v0.1.0
c735ce1 
 ## [0.1.0](v0.0.2...v0.1.0) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented May 7, 2023

🎉 This PR is included in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlonStark AlonStark AlonStark left review comments

Assignees
No one assigned
Labels
released on @dev released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @AlonStark