Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require from module's root returns an empty object. #20

Merged
merged 5 commits into from Nov 14, 2023
Merged

fix: require from module's root returns an empty object. #20

merged 5 commits into from Nov 14, 2023

Conversation

madmonl-starkware
Copy link
Contributor

@madmonl-starkware madmonl-starkware commented Nov 14, 2023 •
edited

Fixed #19
In this PR I added support for both esm and cjs by changing the build from webpack to vite with the appropriate format config.

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the convention: <type>[optional scope]: <description>, e.g: fix: minor typos in code

@madmonl-starkware madmonl-starkware changed the title Fix([#19](https://github.com/starkware-libs/starkware-crypto-utils/issues/19)): require from module's root returns an empty object. Fix([#19]): require from module's root returns an empty object. Nov 14, 2023
@madmonl-starkware madmonl-starkware changed the title Fix([#19]): require from module's root returns an empty object. Fix: require from module's root returns an empty object. Nov 14, 2023
@madmonl-starkware madmonl-starkware marked this pull request as ready for review November 14, 2023 08:44
@dan-ziv dan-ziv changed the title Fix: require from module's root returns an empty object. fix: require from module's root returns an empty object. Nov 14, 2023
@dan-ziv dan-ziv self-requested a review November 14, 2023 11:48
@dan-ziv dan-ziv merged commit e141e88 into starkware-libs:dev Nov 14, 2023
2 checks passed
dan-ziv pushed a commit that referenced this pull request Nov 14, 2023
@semantic-release-bot
prerelease: v0.2.1-dev.1
6cb1d9d 
 ### [0.2.1-dev.1](v0.2.0...v0.2.1-dev.1) (2023-11-14)

### 🔧 Fixes

* require from module's root returns an empty object. ([#20](#20)) ([e141e88](e141e88))
@dan-ziv
Copy link
Collaborator

dan-ziv commented Nov 14, 2023

🎉 This PR is included in version 0.2.1-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request Nov 15, 2023
@semantic-release-bot
release: v0.2.1
754abae 
 ### [0.2.1](v0.2.0...v0.2.1) (2023-11-15)

### 🔧 Fixes

* require from module's root returns an empty object. ([#20](#20)) ([e141e88](e141e88))

### 💉 Improvements

* optimize `pedersen` function ([#17](#17)) ([c73ee56](c73ee56))
@dan-ziv
Copy link
Collaborator

dan-ziv commented Nov 15, 2023

🎉 This PR is included in version 0.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@naorye2 naorye2 naorye2 approved these changes

Assignees
No one assigned
Labels
released on @dev released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing @starkware-industries/starkware-crypto-utils returns an empty object
3 participants
@madmonl-starkware @dan-ziv @naorye2