Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) #3

Merged
merged 3 commits into from Mar 30, 2022
Merged

feat: new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) #3

merged 3 commits into from Mar 30, 2022

Conversation

dan-ziv
Copy link
Collaborator

@dan-ziv dan-ziv commented Mar 30, 2022 •
edited

Description of the Changes

added implementations for getting private key from eth signature and stark key from private

Check List

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the convention: <type>[optional scope]: <description>, e.g: fix: minor typos in code

@dan-ziv dan-ziv requested a review from AlonStark March 30, 2022 14:51
@dan-ziv dan-ziv changed the title feat: new APIs (getPrivateKeyFromEthSignature,privateToStarkKey) feat: new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) Mar 30, 2022
AlonStark
AlonStark previously approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@AlonStark AlonStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan-ziv dan-ziv changed the base branch from master to dev March 30, 2022 14:58
@dan-ziv dan-ziv dismissed AlonStark’s stale review March 30, 2022 14:58

The base branch was changed.

@dan-ziv dan-ziv merged commit bf4066c into dev Mar 30, 2022
@dan-ziv dan-ziv deleted the feat/newAPIs branch March 30, 2022 14:59
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
910cb51 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented May 7, 2023

🎉 This PR is included in version 0.1.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
99d9b0e 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
37624c7 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
18d34a2 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
6bdcbb9 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
dan-ziv pushed a commit that referenced this pull request May 7, 2023
@semantic-release-bot
prerelease: v0.1.0-dev.1
3c5fff6 
 ## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2023-05-07)

### 🧩 Features

* exporting getAssetSelector function ([#8](#8)) ([1a945b2](1a945b2))
* new APIs (getPrivateKeyFromEthSignature, privateToStarkKey) ([#3](#3)) ([bf4066c](bf4066c))
* typescript support ([#10](#10)) ([bcdb84b](bcdb84b))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented May 7, 2023

🎉 This PR is included in version 0.1.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlonStark AlonStark AlonStark left review comments

Assignees
No one assigned
Labels
released on @dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @AlonStark