Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transient cryptography dependency in testing.test_client.client #711

Merged
merged 2 commits into from Oct 30, 2022
Merged

Fix transient cryptography dependency in testing.test_client.client #711

merged 2 commits into from Oct 30, 2022

Conversation

provinzkraut
Copy link
Member

This changes the implementations of the session-related methods in TestClient to use the actual middleware by constructing fake "Scope" and "ASGIConnection" objects

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

@provinzkraut provinzkraut mentioned this pull request Oct 30, 2022
Merged
4 tasks
@provinzkraut
Copy link
Member Author

The fake scope still needs to be enriched dynamically

Goldziher
Goldziher approved these changes Oct 30, 2022
View reviewed changes
starlite/testing/test_client/client.py Show resolved Hide resolved
starlite/testing/test_client/client.py Show resolved Hide resolved
starlite/testing/test_client/client.py Show resolved Hide resolved
@provinzkraut provinzkraut mentioned this pull request Oct 30, 2022
Closed
4 tasks
@provinzkraut provinzkraut marked this pull request as ready for review October 30, 2022 12:10
@provinzkraut
Fix transient cryptography dependency in testing.test_client.client.
f110348 
This changes the implementations of the session-related methods in `TestClient` to use the actual middleware by constructing fake "Scope" and "ASGIConnection" objects
@provinzkraut
Drop cryptography from application test dependencies
3920150
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

98.5% 98.5% Coverage
0.0% 0.0% Duplication

@provinzkraut provinzkraut merged commit a06084f into main Oct 30, 2022
@provinzkraut provinzkraut deleted the fix-cookie-backend-import-2 branch October 30, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goldziher Goldziher Goldziher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@provinzkraut @Goldziher