Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K9.3/DM1.12 support #22

Open
OKflashlightaholic opened this issue Mar 31, 2023 · 11 comments
Open

K9.3/DM1.12 support #22

OKflashlightaholic opened this issue Mar 31, 2023 · 11 comments

Comments

@OKflashlightaholic
Copy link

Please add a k9.3/ dm1.12 hex support. The dual channel d4sv2 hex works but it enables 200% turbo which doesn't play well with Nichia e21a 3500k and deep red sst20's. The regular hex only turbos the fet channel. Thank you so much for all your hard work on your custom anduril 2 branch. I greatly appreciate the dual channel fireworks mode and the adjustable candle/fireplace mode and lighting mode.

@starryalley
Copy link
Owner

Hi thanks for opening this. I am busy with other things recently so apologies to the late reply.

Since I don't have a k9.3 or a DM1.12, can you let me know what firmwares they are using by default? So I can better know what's the difference between the config. Thanks.

@OKflashlightaholic
Copy link
Author

OKflashlightaholic commented Apr 11, 2023 via email

@SiteRelEnby
Copy link

SiteRelEnby commented Apr 15, 2023

Newer DM1.12s (e.g. mine) use the D4SV2 firmware, at least for ones with the DD FET on the flood channel (not sure about SBT90 ones where the FET is for throw). I think the K9.3 firmware might be a leftover from back when the DM1.12 came with only switching or ramping and you had to reflash to change it.

@OKflashlightaholic
Copy link
Author

OKflashlightaholic commented Apr 15, 2023 via email

@SiteRelEnby
Copy link

SiteRelEnby commented Apr 15, 2023

If you set your 2C style to "ceiling only" you will get level 130 in whichever channel is active, which is essentially disabling 200% turbo, as 130 is the default ceiling for the dual channel D4Sv2.

If you mean you want 2C to always use the FET channel for turbo regardless of previous channel, that'd need code changes, but wouldn't be that hard to do yourself.

You'd want to add a var to https://github.com/starryalley/Anduril2/blob/workspace_rev_647/spaghetti-monster/anduril/ramp-mode.c to store your tint mix, then when going to turbo you'd do something like:

saved_tint = tint;
tint = 1 ; //or tint=254 for the other channel - you may need to experiment to see which is which. My DM1.12 has the FET flood channel as 1 and throw as 254
set_level_and_therm_target(turbo_level);

and then replace the code coming out of turbo with

tint = saved_tint;
set_level_and_therm_target(memorized_level);

@OKflashlightaholic
Copy link
Author

OKflashlightaholic commented Apr 15, 2023 via email

@SiteRelEnby
Copy link

Here's a quick proof of concept with .hex files for 1 and 254 and source. Not tested but it's a 4 line change so "if it compiles. it works" in this case.

starryalley_d4sv2-tintramp-fet_channel-specific-turbo.tar.gz
starryalley_d4sv2-tintramp-fet_channel-specific-turbo.zip

Probably not something that could be easily baked into it without adding too much code size, but as a DM1.12 fan I had to help :P

@OKflashlightaholic
Copy link
Author

OKflashlightaholic commented Apr 15, 2023 via email

@OKflashlightaholic
Copy link
Author

OKflashlightaholic commented Apr 15, 2023 via email

@SiteRelEnby
Copy link

SiteRelEnby commented Apr 16, 2023

Ah, I didn't think about changing the default 2C style. Set your 2C style to "ceiling only" and ceiling to 130.

@starryalley
Copy link
Owner

Thanks @SiteRelEnby for jumping in to assist. Yeah I agree that this needs some code change to do what you need but setting 2C style to ceiling only should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants