Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(memory_usage): Update example to have disabled = false #1027

Merged
merged 1 commit into from Mar 23, 2020

Conversation

niwatoliver
Copy link
Contributor

Description

Add to disabled = true to [memory_usage] in the config documentation

Motivation and Context

Closes #1023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @minakawa-daiki. 😊
When changing the configuration docs, the only file that needs changing is https://github.com/starship/starship/blob/master/docs/config/README.md. All other files are updated in a PR by Crowdin, once the translations have been reviewed at http://translate.starship.rs/.

The PR should be ready to merge as soon as it is updated to only change the original config file. 👍

@niwatoliver
Copy link
Contributor Author

niwatoliver commented Mar 23, 2020

I understood. I fix it like that!

Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍
Thank you for your contribution, @minakawa-daiki. 😊

@matchai matchai changed the title docs: Add disabled = true to [memory_usage] section in docs docs(memory_usage): Update example to have disabled = false Mar 23, 2020
@matchai matchai merged commit 4e0382d into starship:master Mar 23, 2020
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add disable = false to [memory_usage] section in config documentation
2 participants