perf(dotnet): fail faster in the dotnet module #1034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For finding the necessary files to determine the version and if the module should be enabled the
dotnet
module is currently iterating through all files in the current directory (O(n)
) to find relevant files.This PR makes the module exit early in case the relevant files aren't present and only does the work of finding these files if they are present.
Possible breakage:
estimate_dotnet_version
is case insentive butcontext.is_match()
is not.Motivation and Context
Tested with hyperfine in
starship/src/modules
:before:
starship module dotnet 63.9 ms ± 4.6 ms
after:
starship module dotnet 23.9 ms ± 2.5 ms
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: