Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update Python to 3.8.2 #1181

Merged
merged 1 commit into from May 8, 2020
Merged

ci: Update Python to 3.8.2 #1181

merged 1 commit into from May 8, 2020

Conversation

johnletey
Copy link
Contributor

@johnletey johnletey commented May 8, 2020 •
edited

Description

Stop test failure caused by Python 3.7.6 being made unavailable in the latest GitHub Actions images.

Motivation and Context

Closes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@johnletey johnletey changed the title ci(python): Fix broken tests ci: Update Python to 3.8.2 May 8, 2020
@johnletey johnletey mentioned this pull request May 8, 2020
Merged
8 tasks
heyrict
heyrict approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@heyrict heyrict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the future it would be better to have a mocked python command.

@johnletey
Copy link
Contributor Author

@heyrict I completely agree! I can open a new PR that implements this

@andytom
Copy link
Member

andytom commented May 8, 2020

@heyrict I completely agree! I can open a new PR that implements this

We might need to work on #941 (and possibly #942) first, so that we can support mocking env vars.

@andytom andytom merged commit a3e12a1 into starship:master May 8, 2020
@johnletey johnletey deleted the fix/broken_python_tests branch May 8, 2020 13:38
@heyrict heyrict mentioned this pull request May 8, 2020
Merged
8 tasks
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
@dagbrown
ci: Update Python to 3.8.2 (starship#1181)
6e4ca68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyrict heyrict heyrict approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnletey @andytom @heyrict