Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swift): Add Swift module #1261

Merged
merged 2 commits into from Jul 29, 2020
Merged

Conversation

vladimyr
Copy link
Member

@vladimyr vladimyr commented May 26, 2020

Description

Added the module which displays the currently installed Swift version.

Motivation and Context

Closes #1245

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@andytom andytom changed the title Swift module Feat(swift): Add Swift module May 28, 2020
@andytom andytom changed the title Feat(swift): Add Swift module feat(swift): Add Swift module May 28, 2020
@andytom andytom requested a review from a team May 31, 2020 20:08
@vladimyr vladimyr force-pushed the swift-module branch 3 times, most recently from 3cb44de to 36e0f62 Compare July 14, 2020 01:13
@vladimyr
Copy link
Member Author

Updated to use format strings 🎉

@vladimyr vladimyr force-pushed the swift-module branch 3 times, most recently from 78e783e to 07b51c6 Compare July 21, 2020 05:29
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to update the docs at around line 210 to include the new module but otherwise LGTM.

@vladimyr
Copy link
Member Author

You have to update the docs at around line 210 to include the new module but otherwise LGTM.

Thanks, missed that 👍
It should be ok now.

@vladimyr vladimyr requested a review from a user July 24, 2020 02:57
@matchai matchai merged commit feb4124 into starship:master Jul 29, 2020
@vladimyr vladimyr deleted the swift-module branch July 29, 2020 16:22
@factotvm
Copy link

Should this be added to v0.45.0?

chipbuster pushed a commit to chipbuster/starship that referenced this pull request Jan 14, 2021
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Swift lang module
3 participants