Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(powershell): Fix session key syntax error #1697

Merged
merged 1 commit into from Sep 30, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Sep 30, 2020

Description

Applies the suggestions form #1696.
Powershell had errors evaluating our session key because the full path replaces ::STARSHIP:: which Powershell didn't like.

Motivation and Context

Closes #1696

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@matchai matchai merged commit 2650dc8 into master Sep 30, 2020
@matchai matchai deleted the fix/powershell-session branch September 30, 2020 16:14
chipbuster pushed a commit to chipbuster/starship that referenced this pull request Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default initialisation for powershell fails on windows
2 participants