docs: Add note about Crowdin-managed files to CONTRIBUTING.md #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipbuster
changed the title
chipbuster
changed the title
chipbuster
changed the title
chipbuster
added a commit
to chipbuster/starship
that referenced
this pull request
Dec 31, 2020
chipbuster
added a commit
to chipbuster/starship
that referenced
this pull request
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a note to CONTRIBUTING.md which specifies that Crowdin-generated files should not be changed in PRs.
Motivation and Context
Changing Crowdin-translated pages seems to be common point of confusion for PRs (especially those that edit docs in a way that seems like translation should be trivial, e.g. whitespace change or emoji changes). @twpol noted on #1983 that they looked for a note in CONTRIBUTING.md about that and couldn't find one.
This is a bit of a draft, so I'm very open to changing the wording on this.
Screenshots (if appropriate):
How Has This Been Tested?
Documentation change.
Checklist: