fix(docker_context): enable if either yml or yaml is found #2053
Conversation
There was a problem hiding this comment.
LGTM, can you also update the docs in https://github.com/starship/starship/tree/master/docs/config#docker-context.
|
Along with an addition to docs, it would be good if we had a test to cover this new code path. |
|
I'm not sure how to write the test. |
|
I was going to suggest following the existing tests for the docker_context module, but....we have no tests in there. Why don't we have tests for the docker module? I'm very tired right now so it's possible I'm just forgetting where they are, but if it turns out that we don't have tests for the docker module, I'd be in favor of merging this PR as-is and then adding tests in a separate PR (or as part of another issue). |
It looks like there are no test for this module. Let's get this merged in and I'll create a separate issue for adding tests. |
|
Thank you for your contribution @benwaffle |
…2053) * fix(docker_context): enable if either yml or yaml is found * Update docs
Description
If
only_with_files = trueis set for the docker_context module, then this prompt is only shown in case aDockerfileordocker-compose.ymlfile is found.This PR also enables it for
docker-compose.yaml(noticeymlvsyaml).Motivation and Context
Fixes the prompt for a valid docker-compose yaml file.
How Has This Been Tested?
~/path/to/dev/build/target/starship prompt docker_contextChecklist: