feat: allow changing default command timeout #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/master: perf(username): get uid without external command (starship#2286) chore: update Discord link to use vanity URL
andytom
reviewed
Feb 9, 2021
Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com>
|
Is this feature updated to the document? I can't find it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new global configuration option
command_timeoutwhich allows changing the default command timeout. This is mainly achieved by moving most of the usage ofutils::exec_cmdtoContext. This should also allow for dynamic command mocking in the future.Motivation and Context
Closes #2243
Related #942
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: