Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(log): change output colors to shades of blue for trace and debug #2299

Merged
merged 1 commit into from Feb 13, 2021

Conversation

alexmaco
Copy link
Contributor

Description

Make the colors for debug and trace log levels more visible.

Motivation and Context

Black and dark grey are illegible on terminals with dark backgrounds. Shades of blue work on light backgrounds as well.
Suggestions welcome for other colors that may be a better compromise.

Screenshots (if appropriate):

image

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

…ebug to make them more visible; black and dark grey are illegible on dark backgrounds
@andytom andytom merged commit 3772b48 into starship:master Feb 13, 2021
@andytom
Copy link
Member

andytom commented Feb 13, 2021

Thank you for your contribution @alexmaco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants