refactor: allow passing OsStr as-is to exec_cmd
#2997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
utils::exec_cmd
andcontext.exec_cmd
to acceptAsRef<OsStr>
(this includes&str
) instead of&str
likeCommand
fromstd
.This allows passing the git folder in the
-C
argument without.to_string_lossy()
(which wouldn't work in the lossy case, but this fix still doesn't seem to fix the issue).Motivation and Context
Closes #
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: