Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status): Showing exit code 0 with pipelines #3028

Merged
merged 1 commit into from Sep 1, 2021

Conversation

andytom
Copy link
Member

@andytom andytom commented Sep 1, 2021

Description

Have fixed a bug there the status module was showing when the exit code
was 0.

Motivation and Context

Closes #3020

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Have fixed a bug there the status module was showing when the exit code
was 0.
@andytom andytom requested a review from a team September 1, 2021 18:27
@andytom andytom marked this pull request as ready for review September 1, 2021 18:39
@andytom andytom merged commit 3933553 into starship:master Sep 1, 2021
@andytom andytom deleted the fix/pipeline_status branch September 1, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shell exit status code is sometimes shown even if it is zero
2 participants