Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use an alternative caching method #3057

Merged
merged 3 commits into from
Sep 21, 2021
Merged

ci: use an alternative caching method #3057

merged 3 commits into from
Sep 21, 2021

Conversation

Milo123459
Copy link
Contributor

Description

This implements a system for caching dependencies.

Motivation and Context

Closes #

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

This makes the CI run faster

@matchai
Copy link
Member

matchai commented Sep 21, 2021

@Milo123459 What does this caching solution do that we wouldn't get with the actions/cache solution that was previously commented out?

@Milo123459
Copy link
Contributor Author

Caches more and it's smarter

@davidkna
Copy link
Member

davidkna commented Sep 21, 2021

It's also supposed to fix the issue that caused the macOS cache to break builds, but it looks like that has already been handled in actions/cache. This post goes into some detail regarding how Swatinem/rust-cache is smarter.

@matchai matchai merged commit 888a653 into starship:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants