-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fill): Add terminal-width
argument to explicitly define terminal's width
#3090
Conversation
I've tested with |
@davidkna Do I need to make any more changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond my comments LGTM
Done |
I didn't realize that rebasing onto master doesn't fix the conflict (one of the hazards of rewriting history I guess). |
Hey @chipbuster |
I went ahead and resolved the merge conflicts for you (101ced5). Sorry I forgot to follow up in Discord--it was late and I was pretty tired. |
@rashil2000 Thanks for the fix! |
Description
This adds a new commandline option for the
prompt
subcommand, called--terminal-width
. Without this fix, the fill module does not work on Windows as the prompt functions (of any shell) always assume a non-interactive terminal, which leads toterm_size
crate reporting a zero width.This argument's value is only used as a fallback, so it will likely not affect macOS/Linux.
Motivation and Context
Closes #3086
Screenshots (if appropriate):
None
How Has This Been Tested?
Checklist: