Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Add copy button for code snippets via plugin #3118

Merged
merged 3 commits into from
Oct 6, 2021

Conversation

ps173
Copy link
Contributor

@ps173 ps173 commented Oct 4, 2021

Description

I added this plugin to vuepress. This plugin adds a copy to clipboard button for all the code snippets. I think this a handy feature to have

Motivation and Context

Closes #3116
Closes #2960

Screenshots (if appropriate):

starshipfix

How Has This Been Tested?

  • [ x] I have tested using Linux

@chipbuster chipbuster changed the title fixes #3116 feat(docs): Add copy button for code snippets via plugin Oct 4, 2021
@chipbuster
Copy link
Contributor

Hi @ps173,

Unfortunately, our Semantic PR bot is a stickler for commit titles (since we won't be able to rebase-and-squash when merging single commits).

Could you remake this commit with a semantic PR title (e.g. "feat(docs): Add copy button for code snippets via plugin") and then force-push on the branch so that we can check that the deploy is working as intended? Thanks!

@ps173
Copy link
Contributor Author

ps173 commented Oct 5, 2021

tell me if any other change is necessary :) And thanks again for guiding me

@chipbuster
Copy link
Contributor

Okay, this looks fine to me. I don't usually muck about with the website portions that heavily, so I'm waiting on confirmation from the rest of the team that we're okay with adding this plugin as a website dependency, and then we should be good to merge.

Copy link
Contributor

@chipbuster chipbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we're golden. Thanks for the contribution, @ps173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code copy button in documentation site Copy to Clipboard like GitHub on Docs Site
2 participants