fix: Modules not working in fish RPROMPT #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix some modules not working correctly in the fish `RPROMPT`. I have done this the very naive way by simply duplicating the code that is currently in the `fish_prompt` function to avoid having to change the scope of any of the variables (currently all local).
|
Is it possible to just change the visibility of the variables in the first |
I thought of that but wasn't sure if |
davidkna
reviewed
Oct 13, 2021
| case '*' | ||
| set STARSHIP_KEYMAP insert | ||
| end | ||
| set STARSHIP_CMD_STATUS $status |
There was a problem hiding this comment.
status is still always 0 for me, even with this change.
There was a problem hiding this comment.
Tested again, and it seems to work when I disabled other shell hooks.
davidkna
approved these changes
Oct 21, 2021
This was referenced Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should fix some modules not working correctly in the fish
RPROMPT. I have done this the very naive way by simply duplicating thecode that is currently in the
fish_promptfunction to avoid having tochange the scope of any of the variables (currently all local) but happy to
change this if someone has a better suggestion.
Motivation and Context
Closes #3137
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: