Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deno): detect deno.json and deno.jsonc #3220

Merged
merged 9 commits into from
Dec 30, 2021
Merged

feat(deno): detect deno.json and deno.jsonc #3220

merged 9 commits into from
Dec 30, 2021

Conversation

maximousblk
Copy link
Contributor

@maximousblk maximousblk commented Nov 10, 2021

Description

add deno.json and deno.jsonc to default detected files list

Motivation and Context

Deno added support for config files in 1.14 and suggest using deno.json and deno.jsonc as file names in the Deno Manual

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@chipbuster
Copy link
Contributor

@maximousblk Is this ready for review? It's still marked as draft right now, so I can't review it.

@maximousblk
Copy link
Contributor Author

sorry i forgot about this 😅. i'll update it in a bit

@maximousblk maximousblk marked this pull request as ready for review December 21, 2021 05:21
@maximousblk
Copy link
Contributor Author

@chipbuster it's ready now

@matchai
Copy link
Member

matchai commented Dec 21, 2021

@maximousblk could you please undo the changes to the non-English docs.
Those files are auto-generated by Crowdin, so making changes to them is likely to cause conflicts down the line.

@maximousblk
Copy link
Contributor Author

done 👍

Copy link
Contributor

@chipbuster chipbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

@andytom andytom merged commit f48c7a2 into starship:master Dec 30, 2021
@andytom
Copy link
Member

andytom commented Dec 30, 2021

Thank you for your contribution @maximousblk and thanks for the review @chipbuster and @matchai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants