ci: Change branch detection method for crowdin #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perniciosius
pushed a commit
to Perniciosius/starship
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the branch detection method from an envar (which has known issues) to something API-based.
Motivation and Context
Hopefully fixes the issue with crowdin PRs (e.g. #3460) where changes are being inappropriately blocked.
Screenshots (if appropriate):
How Has This Been Tested?
Checked that the appropriate properties exist and appear to match using the Github JSON API--unfortunately, these types of changes can really only be tested in production.
Checklist: