Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: starship bug-report sets syntax highlighting for config file #3529

Merged
merged 2 commits into from Jan 28, 2022

Conversation

CLIDragon
Copy link
Contributor

Description

Set the syntax highlighting for the config file in starship bug-report, using the triple backtick syntax.

Motivation and Context

It seemed unintuitive that the syntax highlighting for the config file was set to bash even when it was known that it was in another language, such as powershell or lua.

Screenshots (if appropriate):

How Has This Been Tested?

I have confirmed that this works for powershell, and all tests that pass on master pass on this branch.

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

It seemed unintuitive that the syntax highlighting
for the config file was set to bash even when it was known
that it was in another language, such as powershell or lua.
src/bug_report.rs Outdated Show resolved Hide resolved
Co-authored-by: Kevin Song <4605384+chipbuster@users.noreply.github.com>
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for the fix-up, Joseph! 😄

@matchai matchai merged commit b99d3b8 into starship:master Jan 28, 2022
@CLIDragon CLIDragon deleted the pwsh-format branch January 28, 2022 11:19
Perniciosius pushed a commit to Perniciosius/starship that referenced this pull request Feb 21, 2022
…tarship#3529)

Set the syntax highlighting for the config file in starship bug-report, using the triple backtick syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants