fix(fish): Emit clear-screen escape sequence only in left prompt #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytom
approved these changes
Feb 12, 2022
|
Thanks for the fix @rashil2000, and thanks for reviewing @andytom! |
Perniciosius
pushed a commit
to Perniciosius/starship
that referenced
this pull request
Feb 21, 2022
This was referenced Jun 26, 2022
This was referenced Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emitting the
[Jescape sequence in right prompt caused problems with fish text rendering, like during multiline input and during menu-completion. This PR restricts the escape sequence to just the left prompt part.Motivation and Context
Closes #3305
Closes #3603
Screenshots (if appropriate):
See the linked issue for more details.
How Has This Been Tested?
Checklist: