Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buf): Add Buf module #3661

Merged
merged 13 commits into from Mar 12, 2022
Merged

feat(buf): Add Buf module #3661

merged 13 commits into from Mar 12, 2022

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Feb 26, 2022

Description

Adds support for the Buf CLI tool, an all-in-one tool for working with Protocol Buffers.

Motivation and Context

Alerts users when they've entered a directory in which they can run buf commands.

Screenshots (if appropriate):

image

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

docs/presets/README.md Outdated Show resolved Hide resolved
@lucperkins
Copy link
Contributor Author

@matchai I think it's possible that I may have botched the merge with master. Could you possibly advise?

@matchai
Copy link
Member

matchai commented Mar 9, 2022

Sure thing 👍
I went ahead and fixed up the preset file merge

@lucperkins
Copy link
Contributor Author

Awesome, thanks a lot!

@davidkna davidkna merged commit 16f62d7 into starship:master Mar 12, 2022
@davidkna
Copy link
Member

Thanks for the contribution @lucperkins, and thanks for reviewing @matchai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants