fix(rust): overrides should only check full segments #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it would be awesome if someone could test this on windows, @davidkna perhaps? |
davidkna
reviewed
Mar 2, 2022
Closed
syphar
force-pushed
the
rust-module-version-bug
branch
from
c83523f
to
252013b
Compare
syphar
force-pushed
the
rust-module-version-bug
branch
from
252013b
to
9910cd8
Compare
5 tasks
|
The ninja type-change from variable shadowing. Haven't seriously thought about that one in a while. Thanks @syphar for the fix and for getting this moving! |
1 similar comment
|
The ninja type-change from variable shadowing. Haven't seriously thought about that one in a while. Thanks @syphar for the fix and for getting this moving! |
This was referenced Jun 26, 2022
This was referenced Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix fixes a bug introduced in #3359, an override for
~/some/folderwas also used for~/some/folder_with_suffix. Not the first time that the difference ofPath::starts_withandstr::starts_withbites someone (Path::starts_withonly matches full segments).How Has This Been Tested?
Checklist: