New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws): Add profile aliases #3699
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the config docs for this module too (you only need to update the English version the others will be updated automatically). Side note it is better if you use the template for the PR description.
@andytom I've tried to keep the edits down to a minimum, but sure, I can do some of that. |
Completely missed that there's a PR template, I just did |
This comment was marked as off-topic.
This comment was marked as off-topic.
Your comment is not meaningfully contributing to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add an aws.profile_aliases feature just like aws.region_aliases
Motivation and Context
AWS regions might have slightly irritating names, but it's nothing compared to the enterprise naming schemes sometimes applied to team profile names.
How Has This Been Tested?
Added two simple unit tests, one with and one without similar alias used for region.
Checklist: