Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): Add profile aliases #3699

Merged
merged 5 commits into from Mar 12, 2022
Merged

Conversation

aes
Copy link
Contributor

@aes aes commented Mar 8, 2022

Description

Add an aws.profile_aliases feature just like aws.region_aliases

Motivation and Context

AWS regions might have slightly irritating names, but it's nothing compared to the enterprise naming schemes sometimes applied to team profile names.

How Has This Been Tested?

Added two simple unit tests, one with and one without similar alias used for region.

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@tkey91

This comment was marked as off-topic.

Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the config docs for this module too (you only need to update the English version the others will be updated automatically). Side note it is better if you use the template for the PR description.

src/modules/aws.rs Outdated Show resolved Hide resolved
src/modules/aws.rs Outdated Show resolved Hide resolved
src/modules/aws.rs Outdated Show resolved Hide resolved
@aes
Copy link
Contributor Author

aes commented Mar 9, 2022

@andytom I've tried to keep the edits down to a minimum, but sure, I can do some of that.

@aes
Copy link
Contributor Author

aes commented Mar 9, 2022

Completely missed that there's a PR template, I just did gh pr create -f.

@tkey91

This comment was marked as off-topic.

@matchai
Copy link
Member

matchai commented Mar 9, 2022

Aws is Amazon's server right??

Your comment is not meaningfully contributing to this PR.
Continuing to make non-constructive or offtopic comments will lead to you being blocked from the Starship org's repos.

Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkna davidkna merged commit ac8c2fe into starship:master Mar 12, 2022
@davidkna
Copy link
Member

Thanks for the contribution @aes, and thanks for reviewing @andytom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants