Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add /starship.exe.manifest to Cargo.toml include #3713

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

segevfiner
Copy link
Contributor

Description

Add /starship.exe.manifest to Cargo.toml to fix builds from crates.io.

Motivation and Context

Closes #3709

Screenshots (if appropriate):

N/A

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Contributor

@chipbuster chipbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@davidkna davidkna merged commit 739ab1e into starship:master Mar 9, 2022
@davidkna
Copy link
Member

davidkna commented Mar 9, 2022

Thanks for the fix @segevfiner, and thanks for reviewing @chipbuster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starship fails to update from v1.3.0 to v1.4.0 on Windows 11
3 participants