Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): accept sso credentials #3718

Merged
merged 1 commit into from Mar 16, 2022
Merged

fix(aws): accept sso credentials #3718

merged 1 commit into from Mar 16, 2022

Conversation

davidkna
Copy link
Member

@davidkna davidkna commented Mar 9, 2022

Description

Accept sso_start_url in addition to credential_process. I have not tested this with a real setup.

Motivation and Context

Closes #3717

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@ameeno
Copy link

ameeno commented Mar 10, 2022

should be ok its connected to my bug report.

Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Module in V1.4.0 does not like SSO credential types (Title updated after further investigation)
3 participants