Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): Make AWS_REGION orverrides AWS_DEFAULT_REGION (#3619) #3733

Merged
merged 2 commits into from Mar 14, 2022

Conversation

kuno
Copy link
Contributor

@kuno kuno commented Mar 11, 2022

Description

Making environmental values AWS_REGION overrides AWS_DEFAULT_REGION, if both values is existing.

Motivation and Context

Closes #3619

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left a suggestion but not a blocker.

src/modules/aws.rs Outdated Show resolved Hide resolved
@andytom andytom merged commit 59622bc into starship:master Mar 14, 2022
@andytom
Copy link
Member

andytom commented Mar 14, 2022

Thank you for your contribution @kuno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong order for awscli region value ?
2 participants