Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(status): Make status module work even when the status is 0 #3750

Merged
merged 8 commits into from Mar 16, 2022
Merged

fix(status): Make status module work even when the status is 0 #3750

merged 8 commits into from Mar 16, 2022

Conversation

IzhakJakov
Copy link
Contributor

@IzhakJakov IzhakJakov commented Mar 14, 2022 •
edited

Description

Modify status module work even when the status is 0

Motivation and Context

Closes #3746 and enables a potential workaround for #2967 as well.

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@IzhakJakov
Copy link
Contributor Author

I can test on Linux but don't have access to a Windows machine ATM.

@andytom andytom changed the title Make status module work even when the status is 0 fix(status): Make status module work even when the status is 0 Mar 14, 2022
andytom
andytom reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need to update the English version of the docs, the other languages are handled automatically by Crowdin. If you remove the changes to the non English docs the tests should pass.

@IzhakJakov
Copy link
Contributor Author

I see. I'll do it soon thanks

@IzhakJakov
Copy link
Contributor Author

It's complaining that I fixed indentation?
-- I'll just revert that part then...

matchai
matchai approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Thank you for your contribution @IzhakJakov and for the review @andytom! 😄

@matchai matchai merged commit 8695327 into starship:master Mar 16, 2022
@IzhakJakov
Copy link
Contributor Author

Thank you :)

@Nemo157 Nemo157 mentioned this pull request May 11, 2022
Open
This was referenced Jun 26, 2022
Closed
Merged
Merged
This was referenced Aug 14, 2022
Merged
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Sep 8, 2022
Merged
@github-actions github-actions bot mentioned this pull request Oct 15, 2022
Merged
@github-actions github-actions bot mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytom andytom andytom left review comments

@matchai matchai matchai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

success_symbol option of the status module is being ignored
3 participants
@IzhakJakov @andytom @matchai