Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hostname): add ssh_symbol for ssh connections #3806

Merged
merged 11 commits into from May 4, 2022

Conversation

PatrickChoDev
Copy link
Contributor

@PatrickChoDev PatrickChoDev commented Mar 29, 2022

Description

I've relaunched this module in order to commit to this issue, to add differences between SSH and non-SSH session.

Motivation and Context

Closes #3214

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left some suggestions.

docs/config/README.md Outdated Show resolved Hide resolved
src/configs/hostname.rs Outdated Show resolved Hide resolved
docs/config/README.md Show resolved Hide resolved
@PatrickChoDev PatrickChoDev requested a review from andytom May 1, 2022 11:08
@PatrickChoDev
Copy link
Contributor Author

CI failed isn't my commit. Maybe it's from merging master.

@davidkna davidkna merged commit 2bf30dc into starship:master May 4, 2022
@davidkna
Copy link
Member

davidkna commented May 4, 2022

Thanks for the contribution @PatrickChoDev, and thanks for the review @andytom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the color of hostname if you are on a remote machine
3 participants