Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): move config-schema into docs folder #3878

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

davidkna
Copy link
Member

Description

This PR moves the config schema file from .github/ into docs/.vuepress/public/ instead of using a symlink. The existing symlink path may have been invalid (it is printed in red the GitHub UI).

I also considered moving config schema generation into the deploy step, but that could make it harder to build the docs if it ends up using the file for documentation generation.

Motivation and Context

Closes #

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@matchai matchai changed the title fix: move config-schema into docs folder fix(schema): move config-schema into docs folder Apr 16, 2022
@matchai matchai merged commit 094f982 into starship:master Apr 16, 2022
@davidkna davidkna deleted the config-schema-move branch April 16, 2022 14:17
davidkna added a commit to davidkna/starship that referenced this pull request Apr 18, 2022
davidkna added a commit to davidkna/starship that referenced this pull request Apr 18, 2022
davidkna added a commit that referenced this pull request Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants