fix(git): prevent core.fsmonitor from executing external commands
#3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna
force-pushed
the
git-sec-fsmon
branch
from
37a4d9b
to
e4dcaab
Compare
Closed
andytom
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures
core.fsmonitoris unset unless it is set totrue.I created a
exec_gitwrapper inContext::Repoin order to allow controlling all instances of external git commands centrally. In that function,core.fsmonitoris unset as required.exec_gitalso handles all extra flags previously shared by all external git commands (--no-optional-locks,-C). Some external git commands used-Cand some used--git-dirand--work-treeto set the active repo. I've opted to use both since--work-treeisn't always available.Motivation and Context
Partial fix for #3974
Closes? #4263
Closes #4712
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: