fix(install): ignore tarfile ownership values when installing as root #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can just use the |
davidkna
changed the title
andytom
approved these changes
Jun 5, 2022
This was referenced Jun 26, 2022
This was referenced Aug 14, 2022
This was referenced Feb 25, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the install script used
sudoto install Starship from a tarball, it left the file with what the userid/groupid was in the tarball. That user/group might or might not actually exist. This change fixes that.Description
We now use the
-oflag when untarring, to force tar to use the current user's userid/groupid instead of whatever is in the tarball. That is on by default for non-root users, but not for root.Motivation and Context
Closes #4039
Screenshots (if appropriate):
How Has This Been Tested?
The script claims to support FreeBSD but doesn't - it can't find a binary to download.