feat: add Haxe support #4395
Merged
feat: add Haxe support #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna
requested changes
Oct 3, 2022
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
davidkna
requested changes
Oct 16, 2022
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
removed check for "null" string
davidkna
approved these changes
Dec 2, 2022
|
Thanks for the contribution! |
|
cheers, and thank you for taking the time to give feedback and do code reviews! |
This was referenced Feb 25, 2023
This was referenced Apr 11, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this pull request
Jul 26, 2023
* Add Haxe support * avoid unwrap * fix doc formatting * removed extra newline * fixed formatter and linter issues * fixed config file * better version of detecting contents of .haxerc Co-authored-by: David Knaack <davidkna@users.noreply.github.com> * removed openfl related defaults from detect_files Co-authored-by: David Knaack <davidkna@users.noreply.github.com> * fixed formatting * reworked reading .haxerc with fallback to haxe --version * fixed formatting * added fallback to executable for dev paths in .haxerc * fixed linter issue * added support for Windows paths * use or_else Co-authored-by: David Knaack <davidkna@users.noreply.github.com> * use shorter version with `?` Co-authored-by: David Knaack <davidkna@users.noreply.github.com> * simplified regex check removed check for "null" string * fixed format Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a Haxe module that will display currently installed / active Haxe version when in a directory that contains Haxe related files and folders, e.g. files ending with
.hxor.hxml, or a folder named.haxeliborhaxe_librariesor specific file names used in Haxe development environments.module detects Haxe version either by looking at contents of
.haxercfile (which implies use of lix package manager) or by callinghaxe --version.Motivation and Context
As a developer working on Haxe projects you might have different Haxe versions installed on your system (like current release version and a nightly build) and you switch between them to e.g. test compatibility.
How Has This Been Tested?
This module is similar to e.g. nim module so I took that as a template. I rewrote and added test cases to reflect the differences of Haxe module. then I ran test cases to until all were green. I also ran a debug build during development in my local bash environment.
Checklist: