feat(aws): add a fallback for expiration key
#4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
davidkna
requested changes
Oct 8, 2022
- extend the time range from `-2s,0s` to `-5s,+2s`
davidkna
reviewed
Oct 11, 2022
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
davidkna
approved these changes
Oct 11, 2022
|
@davidkna Would someone merge this soon? 🤔 |
This was referenced Feb 25, 2023
This was referenced Apr 11, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this pull request
Jul 26, 2023
* feat(aws): add a fallback for `expiration` * fix(aws): intermittent test failures - extend the time range from `-2s,0s` to `-5s,+2s` * fix: `docs/config/README.md` readability Co-authored-by: David Knaack <davidkna@users.noreply.github.com> Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For third party login solution like saml2aws. It uses
x_security_token_expiresas the expiration key name.Motivation and Context
Add
x_security_token_expiresas a fallback, so bothexpirationandx_security_token_expiresworks.Closes #4414
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: