feat(preset): Add No Empty Icons preset #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kissaki
force-pushed
the
preset/no-empty-icons
branch
from
945844f
to
f30ccf9
Compare
davidkna
requested changes
Oct 31, 2022
davidkna
reviewed
Oct 31, 2022
davidkna
requested changes
Oct 31, 2022
When toolset files are identified by the Starship module, the default format displays the toolset icon, and additional information. When the toolset executables are not available, the additional information (like version number) is missing. Only the toolset icon is displayed. The No Empty Icons preset changes the format configuration to not show the toolset icons if the variables are empty - presumably because the toolset is not installed or found. Closes starship#3070 Related starship#3248
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Kissaki
force-pushed
the
preset/no-empty-icons
branch
from
cc6f5b0
to
fad8060
Compare
davidkna
approved these changes
Nov 1, 2022
This was referenced Feb 25, 2023
This was referenced Apr 11, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this pull request
Jul 26, 2023
* feat(preset): Add No Empty Icons preset When toolset files are identified by the Starship module, the default format displays the toolset icon, and additional information. When the toolset executables are not available, the additional information (like version number) is missing. Only the toolset icon is displayed. The No Empty Icons preset changes the format configuration to not show the toolset icons if the variables are empty - presumably because the toolset is not installed or found. Closes starship#3070 Related starship#3248 * Remove non-version-related modules from preset Co-authored-by: David Knaack <davidkna@users.noreply.github.com> * Add new module opa to preset Co-authored-by: David Knaack <davidkna@users.noreply.github.com> * Drop unnecessary inner conditional from format Co-authored-by: David Knaack <davidkna@users.noreply.github.com> * Remove commit_hash_length setting from preset * Remove undesired modules Co-authored-by: David Knaack <davidkna@users.noreply.github.com> Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When toolset files are identified by the Starship module, the default format displays the toolset icon, and additional information.
When the toolset executables are not available, the additional information (like version number) is missing. Only the toolset icon is displayed.
The No Empty Icons preset changes the format configuration to not show the toolset icons if the variables are empty - presumably because the toolset is not installed or found.
Closes #3070
Related #3248