feat(localip): use reserved remote address #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipbuster
requested changes
Nov 29, 2022
Instead of the remote address of 8.8.8.8 (Google DNS) in the crate local_ipaddress use a reserved IPv4 address, that should never be assigned. Also forward the underlying error on failure. Supersedes: starship#4614
5 tasks
|
Thank you for your contribution @cgzones and thank you for reviewing @chipbuster. |
This was referenced Feb 25, 2023
This was referenced Apr 11, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this pull request
Jul 26, 2023
Instead of the remote address of 8.8.8.8 (Google DNS) in the crate local_ipaddress use a reserved IPv4 address, that should never be assigned. Also forward the underlying error on failure. Supersedes: starship#4614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of the remote address of 8.8.8.8 (Google DNS) in the crate
local_ipaddressuse a reserved IPv4 address, that should never be assigned.Also forward the underlying error on failure.
Motivation and Context
The current used crate
local_ipaddressconnects an UDP socket to 8.8.8.8 (Google DNS), which might trigger some privacy concerns (although no actual packet should be send).Supersedes: #4614
How Has This Been Tested?
Checklist: