New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nodejs): apply style
even if node version is unavailable
#4713
Conversation
style
even if node version is unavailable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Please also write a test case for this problem (try using .cmd
-mocking from ModuleRenderer
), and if possible, please also fix the other things I pointed out.
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
I've added an unit test and applied the commits that you mentioned. |
Thank you for your contribution @Andree37 |
…hip#4713) * correct nodejs color * Update src/modules/nodejs.rs Co-authored-by: David Knaack <davidkna@users.noreply.github.com> * Update src/modules/nodejs.rs Co-authored-by: David Knaack <davidkna@users.noreply.github.com> * fix: removed unecessary unwraps * test: no node installed * test: no node installed Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
Description
Allowed
nodejs_version
to be unset (node isn't installed) and assign the node configurationMotivation and Context
Closes #4705
Screenshots (if appropriate):
How Has This Been Tested?
Checklist:
I don't believe they are applicable.