Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fennel): add fennel module #4717

Merged
merged 3 commits into from Dec 21, 2022

Conversation

fold-squirrel
Copy link
Contributor

@fold-squirrel fold-squirrel commented Dec 13, 2022

Description

I added a fennel module that displays the current version of fennel.

I followed the checklist from CONTRIBUTING.md, I tried to update the docs/.vuepress/public/presets/toml to the best of my ability.

Motivation and Context

I recently tried using fennel to configure neovim and was annoyed that starship didn't support it, and I also like rust so I decided to add a fennel module.
Closes #4698

Screenshots (if appropriate):

NA

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fold-squirrel
Copy link
Contributor Author

I have a question, I clicked on sync fork on GitHub on my feature branch. so should I have not done that or does it not affect anything. I'm not sure what one should do in this situation.

@chipbuster
Copy link
Contributor

@fold-squirrel Everything still looks green on my end (in fact, I'm not sure what that button did, since I don't see any changes reflected in the commit logs), so I'll go ahead and merge.

@fold-squirrel Thanks for your contribution! Very rare that we get a first-time module contribution that correctly hits all the right points, so props for putting that work in.

@davidkna Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a fennel module
3 participants