fix(git_commit): fix potential test failure #4734
Conversation
src/modules/git_commit.rs
Outdated
| @@ -437,7 +437,7 @@ mod tests { | |||
| .output()?; | |||
|
|
|||
| create_command("git")? | |||
| .args(["tag", "v2"]) | |||
| .args(["describe" , "tag" , "v2"]) | |||
There was a problem hiding this comment.
What sort of failure are you seeing without this? The code here is meant to create a tag, not to run describe. The git tests can have intermittent failures.
There was a problem hiding this comment.
i ran the cargo tests, and saw a test case failed, after adding the describe tag it passes the test case
There was a problem hiding this comment.
But does it pass without your change if you run it again?
There was a problem hiding this comment.
before making changes
There was a problem hiding this comment.
after making changes
There was a problem hiding this comment.
Does it work if you replace:
let git_tag = create_command("git")?
.args([
"for-each-ref",
"--contains",
"HEAD",
"--sort=-taggerdate",
"--count=1",
"--format",
"%(refname:short)",
"refs/tags",
])with this?
let git_tag = create_command("git")?
.args(["describe", "--tags"])If not, please close this and open a bug report, because in my opinion it would mean that the behavior and not the test is incorrect somehow.
There was a problem hiding this comment.
yes it worked after i replaced the code as u mentioned
There was a problem hiding this comment.
In that case, please change your PR to use that instead. I would also appreciate if you changed the other tag tests to use git describe --tags as the baseline instead.
There was a problem hiding this comment.
if u mean changing the block of code u mentioned , then yes, i changed it. there was another instance of same code, so changed that as well with git describe --tags. please review the changes
There was a problem hiding this comment.
ran the test cases, and all of those passed without failures
davidkna
changed the title
Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com>
Changes git command used in tests to avoid potential failures with lightweight tags.
Starship git_commit latest tag lightweight test case failed, i fixed the error to pass the test case