Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove version check for unsupported nushell version #4791

Merged

Conversation

indigolain
Copy link
Contributor

Description

Removed the nu shell version check codes for supporting older versions of nu shell.

Motivation and Context

Closes #4778

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@davidkna davidkna changed the title [chore] Remove version check since we now support nu shell v0.73.0 or greater chore: remove version check for unsupported nushell version Jan 5, 2023
@davidkna
Copy link
Member

davidkna commented Jan 5, 2023

Please also remove the Note: Nushell 0.71.0 or later is require note from the docs regarding rprompt support.

@indigolain
Copy link
Contributor Author

@davidkna
Thank you for the review!
I've removed the note with 381824c.

@chipbuster chipbuster merged commit fcdf2a0 into starship:master Jan 6, 2023
@indigolain indigolain deleted the remove-version-checking-in-nushell-init branch January 7, 2023 03:13
Indyandie pushed a commit to Indyandie/starship that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up nu init script
3 participants