Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use literal toml strings in continuation_prompt docs #4794

Merged
merged 1 commit into from
Jan 7, 2023
Merged

docs: use literal toml strings in continuation_prompt docs #4794

merged 1 commit into from
Jan 7, 2023

Conversation

Marzal
Copy link
Contributor

@Marzal Marzal commented Jan 5, 2023 •
edited

Description

continuation_prompt should be set to a literal string so it should have ' instead of " in the doc/examples.

UPDATE:
Using " even without any variables doesn't work . -> not true, a shell refresh was needed

Motivation and Context

Closes #

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • [ x] I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@Marzal
fix continuation_prompt documentation
ff81f80 
continuation_prompt should be set to a literal string so it should have ' instead of " in the doc/examples
Using " even without any variables doesn't work .

PD: Thanks for this amazing FLOSS project
@davidkna davidkna changed the title fix continuation_prompt documentation docs: use literal toml strings in continuation_prompt docs Jan 5, 2023
davidkna
davidkna approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, both variants should work. Did you refresh your shell after setting the option?

Either way, changing this ensures that ' strings are used more consistently, so thanks for the PR!

@Marzal
Copy link
Contributor Author

Marzal commented Jan 5, 2023

Actually, both variants should work. Did you refresh your shell after setting the option?

Either way, changing this ensures that ' strings are used more consistently, so thanks for the PR!

That's true, normally changes are applied without interaction, but closing and opening konsole did work with " as with '.

I

@davidkna davidkna merged commit 5012f7a into starship:master Jan 7, 2023
Indyandie pushed a commit to Indyandie/starship that referenced this pull request Jul 26, 2023
@Marzal @Indyandie
docs: use literal toml strings in continuation_prompt docs (starshi…
a4c5ba6 
…p#4794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkna davidkna davidkna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Marzal @davidkna